-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: add support for specifying timezone for pod/container #7589
*: add support for specifying timezone for pod/container #7589
Conversation
Skipping CI for Draft Pull Request. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #7589 +/- ##
=======================================
Coverage 48.05% 48.05%
=======================================
Files 148 148
Lines 16339 16374 +35
=======================================
+ Hits 7851 7868 +17
- Misses 7532 7546 +14
- Partials 956 960 +4 |
a81e1c7
to
8950aa6
Compare
8950aa6
to
e83e775
Compare
/retest |
d217184
to
a82ddfd
Compare
/retest |
a82ddfd
to
f82f368
Compare
/retest |
/approve LGTM, @cri-o/cri-o-maintainers PTAL |
47eb307
to
401c959
Compare
Fixes #cri-o#7550 Signed-off-by: Sohan Kunkerkar <[email protected]>
Signed-off-by: Sohan Kunkerkar <[email protected]>
Increase the gocyclo until we refactor the createSandboxContainer function. Signed-off-by: Sohan Kunkerkar <[email protected]>
401c959
to
a38b9b9
Compare
/retest |
/retest-required |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, kannon92, kwilczynski, sohankunkerkar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sohankunkerkar, thank you for working on this! Looks amazing! 🎉 |
/retest |
3 similar comments
/retest |
/retest |
/retest |
/cherry-pick release-1.29 |
@sohankunkerkar: #7589 failed to apply on top of branch "release-1.29":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Addresses #7550
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?