Add version check to crew_chat.py

[devin-ai-integration]

Add version check to crew_chat.py

Added version check to crew_chat.py to ensure users are running crewAI version 0.98.0 or higher when using poetry. This follows the same pattern implemented in run_crew.py.

Changes

• Added version check at the start of run_chat()
• Set minimum required version to 0.98.0
• Added error message for users running older versions with poetry
• Added required imports (packaging.version, get_crewai_version, read_toml)

Testing

The changes were not tested locally as they follow the exact same pattern as the existing implementation in run_crew.py, which is already in production. The implementation is a straightforward version check that doesn't modify any existing functionality.

Link to Devin run: https://app.devin.ai/sessions/d428e525e80f48088d6ff6599c113f61

[devin-ai-integration]

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

• Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
• Look at CI failures and help fix them

⚙️ Control Options:

• Disable automatic comment and CI monitoring

[joaomdmoura]

Disclaimer: This review was made by a crew of AI Agents.

Code Review Comment for PR #1966

Overall Assessment

This pull request introduces a crucial feature by adding version checking functionality to crew_chat.py, ensuring compatibility with the minimum required crewAI version of 0.98.0. The implementation is fundamentally sound and demonstrates an appropriate approach to maintaining compatibility, which can prevent potential issues that users might face with older versions.

Code Quality Findings and Suggestions:

1. Import Statements:

   • Current State: The organization of imports is generally clear.
   • Suggestion: Group imports into three categories: standard libraries, third-party libraries, and local imports to enhance readability. Consider adding type hints where applicable.

   # Standard library imports
   import click
   
   # Third-party imports
   import tomli
   from packaging import version
   
   # Local imports
   from crewai.crew import Crew
   from crewai.llm import LLM
   from crewai.types.crew_chat import ChatInputField, ChatInputs
   from crewai.utilities.llm_utils import create_llm
   from crewai.cli.version import get_crewai_version
   from crewai.cli.utils import read_toml

2. Version Check Implementation:

   • Current State: The logic for version comparison is clear and user-friendly.
   • Suggestions:
     • Enhance error handling by wrapping the version parsing in a try-except block to catch any potential exceptions.
     • Consider defining the minimum required version as a constant for clarity and maintainability.
     • Make the error message more specific, providing the current version and the required version.

   Example:

   try:
       if pyproject_data.get("tool", {}).get("poetry") and (
           version.parse(crewai_version) < version.parse(MIN_REQUIRED_VERSION)
       ):
           click.secho(ERROR_MESSAGE, fg="red")
           return
   except version.InvalidVersion:
       click.secho("Invalid version format detected", fg="red")
       return

3. Function Structure:

   • Current State: The function structure is adequate but can be improved.
   • Suggestion: Extract the version checking code into a separate function to enhance maintainability, clarity, and testability.

   Example:

   def check_version_compatibility(crewai_version: str, pyproject_data: dict) -> bool:
       # ... implementation 

Historical Context from Related PRs

Since related pull requests weren't accessible, I encourage you to review the history of changes made in crew_chat.py and associated files like version.py and utils.py to identify trends in version management and error handling.

Implications for Related Files

Possible impacts of this PR on related files include:

• Version Management: Ensuring that changes in how versioning is handled in crew_chat.py don’t adversely affect version retrieval in version.py.
• Config Changes: Updates in crew_chat.py would require consistent handling in utils.py to ensure that TOML files are properly read.
• Error Propagation: Changes in error handling could influence how errors are reported in related file operations, and maintaining consistent messaging across files will improve user clarity.

Conclusion

This pull request serves its primary function well, but incorporating the suggested improvements can significantly enhance its robustness and maintainability. Thank you for the contribution and attention to detail in ensuring compatibility with crewAI versions!

Please let me know if you'd like to discuss any of the proposed changes further.

[bhancockio]

This not the correct error message to say.

Our message should be along the lines of you are using an older version of crew that doesn't support conversational crews.

Run uv upgrade crewai

[bhancockio]

We don't need this check right? We can get rid of this.

[bhancockio]

Drop unnecessary comments like this and the ones above.