-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add patronus eval tool docs #1850
Add patronus eval tool docs #1850
Conversation
Disclaimer: This review was made by a crew of AI Agents. Code Review Comment for Patronus Evaluator DocumentationOverviewThis pull request adds documentation for three important tools in the Patronus framework:
While the documentation generally provides clear and useful information, several areas require improvement for consistency, clarity, and usability. Recommendations1. Standardize Frontmatter FormattingThe frontmatter should be consistent across all documentation files. For example, ensure that all headers start with the specific YAML formatting. Here’s a corrected example: -
---
title: Patronus Eval Tool
+ ---
+ title: Patronus Eval Tool 2. Consistent Title FormattingTitles must be uniformly formatted to enhance clarity in navigation. For example, the title in the - title: Patronus Eval Tool
+ title: Patronus Predefined Criteria Eval Tool 3. Uniform Link FormattingEnsure all links follow a consistent format, particularly for URLs: - app.patronus.ai](http://app.patronus.ai)
+ [app.patronus.ai](https://app.patronus.ai) 4. Improve Numbered List Formatting and ClarityLists should maintain a clear structure without unintended spaces: - 1. Fetch all available criteria
- 2. Select the most fitting criteria
- 3. Evaluates the inputs/outputs/context
+ 1. Fetch all available criteria
+ 2. Select the most fitting criteria
+ 3. Evaluate the inputs/outputs/context 5. Use Language-Specific Code Block TagsSpecify the language in code snippets for improved clarity and syntax highlighting. For instance: - ```shell
+ ```bash 6. Code Comments in ExamplesAdding comments in code snippets can significantly enhance understanding, especially for new users. Here’s an added comment example: patronus_eval_tool = PatronusLocalEvaluatorTool(
evaluator="local_evaluator_name", # Name of the registered evaluator function
evaluated_model_gold_answer="test" # Expected correct answer for comparison
) 7. Clear Configuration ExampleImprove clarity in configuration examples to avoid confusion: patronus_eval_tool = PatronusPredefinedCriteriaEvalTool(
evaluators=[{
"evaluator": "judge", # Built-in Patronus evaluator
"criteria": "contains-code" # Pre-defined evaluation criteria
}]
) 8. Additional Recommendations
Positive Aspects
ConclusionThe documentation lays a strong foundation for using the Patronus evaluator tools but can greatly benefit from these adjustments. By incorporating these suggestions, we will enhance the quality, clarity, and maintainability of the documentation, ultimately improving the user experience. Thank you for your efforts to improve the Patronus documentation! I look forward to seeing these enhancements implemented. |
Hey @Rebecca-Qian! Can you please merge in main and shoot me a message when you do so I can get this merged in? Thank you for updating these docs! |
Hey @Rebecca-Qian! Can you please update this PR to allow edits by maintainer so I can update this branch? Steps for the Contributor: |
Closing due to inactivity. |
Adding docs for the following: