Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: enso api route get #49

Merged
merged 3 commits into from
Jan 17, 2025
Merged

Feat: enso api route get #49

merged 3 commits into from
Jan 17, 2025

Conversation

TxCorpi0x
Copy link
Contributor

Description

Please include a summary of the changes and the related issue.

Adds support for Enso API to get the swap route shortcuts in detail.

Type of Change

  • Bugfix
  • New Feature
  • Improvement
  • Documentation Update

Checklist

  • I have read the contributing guidelines.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Related Issue

Closes #[issue number]

@TxCorpi0x TxCorpi0x requested a review from hyacinthus January 16, 2025 06:47
@TxCorpi0x TxCorpi0x changed the title feat: enso api route get Feat: enso api route get Jan 16, 2025
skills/enso/__init__.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@hyacinthus hyacinthus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, for this skill, I think there are too many parameters; AI cannot possibly master that many. We can predefine some less important parameters and limit the AI to filling out no more than three, and at most five. Even three can easily lead to errors.

@TxCorpi0x
Copy link
Contributor Author

Additionally, for this skill, I think there are too many parameters; AI cannot possibly master that many. We can predefine some less important parameters and limit the AI to filling out no more than three, and at most five. Even three can easily lead to errors.

The route and quote APIs have a lot of input values and they can be filled according to the user's need. I put all of them but just 5 of them fromAddress: str, amountIn: list[int], tokenIn: list[str], tokenOut: list[str] are mandatory.
I agree with to reduce parameter input count, do you mind to do it in this PR or or a separate enhancement?

@hyacinthus hyacinthus merged commit 72b3a83 into main Jan 17, 2025
4 checks passed
@hyacinthus hyacinthus deleted the feat/enso-route branch January 17, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants