Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable swap on the node #864

Open
wants to merge 2 commits into
base: release-4.15
Choose a base branch
from

Conversation

praveenkumar
Copy link
Member

After switching to OVN-K we observed increase in memory resource and one
way to tackle it to have swap enabled on the node.

This PR is try to do following.

@openshift-ci openshift-ci bot requested review from anjannath and cfergeau March 15, 2024 07:05
Copy link

openshift-ci bot commented Mar 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from praveenkumar. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@praveenkumar
Copy link
Member Author

I am going to update the bundle size and resource consumption after testing the bundle.

/hold till then.

@praveenkumar
Copy link
Member Author

/retest

4 similar comments
@praveenkumar
Copy link
Member Author

/retest

@praveenkumar
Copy link
Member Author

/retest

@praveenkumar
Copy link
Member Author

/retest

@praveenkumar
Copy link
Member Author

/retest

After switching to OVN-K we observed increase in memory resource and one
way to tackle it to have swap enabled on the node.

This PR is try to do following.
- Enable only `NodeSwap` feature gate instead complete Tech preview
  features.
     - https://docs.openshift.com/container-platform/4.15/rest_api/config_apis/featuregate-config-openshift-io-v1.html
- Add `swapaccount=1` to kernel argument which is required for the swap
    - https://docs.openshift.com/container-platform/4.15/nodes/nodes/nodes-nodes-managing.html#nodes-nodes-swap-memory_nodes-nodes-managing
- Add swap feature to kubelet config
- Add systemd unit file to create swap and enable it
- Extend the disk size by 4GB because that much of space used for swap
Since 4.15 now released better to update the MIRROR and respective
channel accordingly.
@cfergeau
Copy link
Contributor

Missing Fixes: https://github.com/crc-org/snc/issues/861 line (had to go search for it for some additional context I knew was there)

@praveenkumar
Copy link
Member Author

/retest

Copy link

openshift-ci bot commented Mar 18, 2024

@praveenkumar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-snc fd5d387 link true /test e2e-snc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gbraad
Copy link
Collaborator

gbraad commented Mar 20, 2024

Hold?

@praveenkumar
Copy link
Member Author

/hold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants