-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move OKD bundle from FCOS to SCOS #840
Conversation
/hold Looks like the release doesn't contain the windows oc binary (asked on the internal slack about it will update here once get some answer) |
eeaa1a6
to
7c1a8b1
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Since `okd-scos` is better upstream for OCP than FCOS one. It also have pre-release version of 4.15 so switching OKD bundles to it. - https://github.com/okd-project/okd-scos
As of now oc client for windows are not release as part of okd-scos project so it fails but this is mostly the issue in the release pipeline which need to be fixed. Until now we are hardcoded oc dowload binary from https://github.com/okd-project/okd release. - okd-project/okd-scos#17
7c1a8b1
to
0b03587
Compare
New changes are detected. LGTM label has been removed. |
@praveenkumar: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/unhold going to merge to create OKD bundle for test. |
/cherry-pick release-4.15 |
@praveenkumar: new pull request created: #842 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Since
okd-scos
is better upstream for OCP than FCOS one. It also have pre-release version of 4.15 so switching OKD bundles to it.