Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move OKD bundle from FCOS to SCOS #840

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Conversation

praveenkumar
Copy link
Member

Since okd-scos is better upstream for OCP than FCOS one. It also have pre-release version of 4.15 so switching OKD bundles to it.

@openshift-ci openshift-ci bot requested review from anjannath and gbraad January 23, 2024 09:22
@praveenkumar
Copy link
Member Author

/hold

Looks like the release doesn't contain the windows oc binary (asked on the internal slack about it will update here once get some answer)

Copy link

openshift-ci bot commented Jan 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Since `okd-scos` is better upstream for OCP than FCOS one. It also have
pre-release version of 4.15 so switching OKD bundles to it.

- https://github.com/okd-project/okd-scos
As of now oc client for windows are not release as part of okd-scos
project so it fails but this is mostly the issue in the release pipeline
which need to be fixed. Until now we are hardcoded oc dowload binary
from https://github.com/okd-project/okd release.

- okd-project/okd-scos#17
Copy link

openshift-ci bot commented Jan 24, 2024

New changes are detected. LGTM label has been removed.

Copy link

openshift-ci bot commented Jan 24, 2024

@praveenkumar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-snc 0b03587 link true /test e2e-snc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@praveenkumar
Copy link
Member Author

/unhold

going to merge to create OKD bundle for test.

@praveenkumar praveenkumar merged commit aafb996 into crc-org:master Jan 24, 2024
2 of 4 checks passed
@praveenkumar
Copy link
Member Author

/cherry-pick release-4.15

@openshift-cherrypick-robot

@praveenkumar: new pull request created: #842

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants