Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix podman static binary for linux which now have arch info #663

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

praveenkumar
Copy link
Member

podman-remote linux binary now have arch info and binary is placed under bin folder before creating the tarball. We now need to extract it with bin folder and remove it after moving it to correct location.

$ curl -L -O https://github.com/containers/podman/releases/download/v4.4.1/podman-remote-static-linux_amd64.tar.gz
$ tar -tf podman-remote-static-linux_amd64.tar.gz
./bin/podman-remote-static-linux_amd64

fix #662

@openshift-ci openshift-ci bot requested review from anjannath and gbraad March 9, 2023 08:35
@openshift-ci
Copy link

openshift-ci bot commented Mar 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gbraad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Mar 9, 2023
@cfergeau
Copy link
Contributor

cfergeau commented Mar 9, 2023

and binary is placed under bin folder before creating the tarball.

This is only the case for 4.4.1, 4.4.2 does not have a bin/ directory. A similar patch would be good to have in master as well to keep both files in sync.

@praveenkumar
Copy link
Member Author

and binary is placed under bin folder before creating the tarball.

This is only the case for 4.4.1, 4.4.2 does not have a bin/ directory. A similar patch would be good to have in master as well to keep both files in sync.

@cfergeau on the master we will have this patch once RHCOS have 4.4.1, as of now it is 4.2.0 https://releases-rhcos-art.apps.ocp-virt.prod.psi.redhat.com/contents.html?stream=prod/streams/4.12&release=412.86.202303071430-0&arch=x86_64

@praveenkumar
Copy link
Member Author

This is only the case for 4.4.1, 4.4.2 does not have a bin/ directory.

@cfergeau yes, I am not sure why they keep changing the file structure for each binary :( will keep #662 issue open for tracking issue.

podman-remote linux binary now have arch info and binary is placed under
bin folder before creating the tarball. We now need to extract it with
bin folder and remove it after moving it to correct location.
```
$ curl -L -O https://github.com/containers/podman/releases/download/v4.4.1/podman-remote-static-linux_amd64.tar.gz
$ tar -tf podman-remote-static-linux_amd64.tar.gz
./bin/podman-remote-static-linux_amd64
```
@openshift-ci
Copy link

openshift-ci bot commented Mar 9, 2023

New changes are detected. LGTM label has been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants