Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test (config) : Add some unit tests for config settings #4536

Merged

Conversation

rohanKanojia
Copy link
Contributor

@rohanKanojia rohanKanojia commented Jan 2, 2025

Description

Relates to: #3832, PR #4451

Extracted some unit tests out of #4451 as I needed them while working on #3832

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Proposed changes

These unit tests verify these scenarios for config:

  • when we try to set invalid key, throw error
  • whether default key values are as expected
  • whether we're able to override default values by providing new value

Testing

N/A

Contribution Checklist

  • I Keep It Small and Simple: The smaller the PR is, the easier it is to review and have it merged
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Which platform have you tested the code changes on?
    • Linux
    • Windows
    • MacOS

Extracted some unit tests out of crc-org#4451 as I was need them
while working on crc-org#3832

These unit tests verify these scenarios for config:
- when we try to set invalid key, throw error
- whether default key values are as expected
- whether we're able to override default values by providing new value

Signed-off-by: Rohan Kumar <[email protected]>
Copy link

openshift-ci bot commented Jan 2, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign praveenkumar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Jan 2, 2025

@rohanKanojia: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/integration-crc 1789aeb link true /test integration-crc
ci/prow/e2e-crc 1789aeb link true /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@praveenkumar praveenkumar merged commit c08e41a into crc-org:main Jan 2, 2025
28 of 36 checks passed
@rohanKanojia rohanKanojia deleted the pr/settings_test_parameterized branch January 2, 2025 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants