Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix : remove unnecessary logging for crc-exists file (#3676) #4532

Merged
merged 1 commit into from
Jan 2, 2025
Merged

fix : remove unnecessary logging for crc-exists file (#3676) #4532

merged 1 commit into from
Jan 2, 2025

Conversation

rohanKanojia
Copy link
Contributor

Description

Fixes: #3676.

Remove unnecessary debug log statement for crc-exists file from filestore Exists() method

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Proposed changes

Remove unnecessary debug log statement for crc-exists file from filestore Exists() method

Testing

  1. Start CRC cluster and monitor crc.log file
  2. It should not have redundant log statement for checking crc-exists file

Contribution Checklist

  • I Keep It Small and Simple: The smaller the PR is, the easier it is to review and have it merged
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Which platform have you tested the code changes on?
    • Linux
    • Windows
    • MacOS

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 30, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 30, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign anjannath for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rohanKanojia rohanKanojia marked this pull request as ready for review December 30, 2024 07:01
@openshift-ci openshift-ci bot requested review from anjannath and cfergeau December 30, 2024 07:01
praveenkumar
praveenkumar reviewed Dec 31, 2024
View reviewed changes
pkg/libmachine/persist/filestore.go
@@ -83,7 +83,6 @@ func (s Filestore) SetExists(name string) error {
func (s Filestore) Exists(name string) (bool, error) {
filename := filepath.Join(s.MachinesDir, name, fmt.Sprintf(".%s-exist", name))
_, err := os.Stat(filename)
log.Debugf("Checking file: %s", filename)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is useful for debugging so I would suggest instead of complete remove better to move it to os.IsNotExist block and change message around file not found: filename.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I've moved the debug statement to os.IsNotExist block

@rohanKanojia
fix : remove unnecessary logging for crc-exists file (crc-org#3676)
9a41c51 
Remove unnecessary debug log statement for crc-exists file from
filestore Exists() method. Only log debug statement when crc-exists file
is not found.

Signed-off-by: Rohan Kumar <[email protected]>
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 2, 2025

@rohanKanojia: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/integration-crc 9a41c51 link true /test integration-crc
ci/prow/e2e-crc 9a41c51 link true /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@praveenkumar praveenkumar merged commit d89df4c into crc-org:main Jan 2, 2025
29 of 36 checks passed
@gbraad
Copy link
Contributor

gbraad commented Jan 2, 2025

/me high-fives @rohanKanojia; "Yes! Finally ..." ✋

@rohanKanojia rohanKanojia deleted the pr/issue3676 branch January 2, 2025 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praveenkumar praveenkumar praveenkumar left review comments

@anjannath anjannath Awaiting requested review from anjannath

@cfergeau cfergeau Awaiting requested review from cfergeau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Unnecessary logging crc-exists every second on Windows grows crcd.log
3 participants
@rohanKanojia @gbraad @praveenkumar