-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase memory resource from 9126 to 10752 #4066
Conversation
f9d5698
to
b68bb07
Compare
Fwiw, I've found strongunits https://github.com/crc-org/vfkit/blob/main/pkg/config/config.go#L40-L46 relatively useful when dealing with MiB/... to know in which unit a value is. I assume if someone set the cluster memory to 10000 previously, then they will get a failure after the upgrade, and will have to unset or raise the cluster memory size? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The difference is 1536M.
Let's see how this will work out...
/lgtm for testing
Yeah, I will put another commit to fix it.
Yeah, that's right. |
What is the status of this? |
@gbraad looks like we have to go with this because swap is not working as expected crc-org/snc#861 have all the details and crc-org/snc#861 (comment) is where we filled the jira. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gbraad The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
e423afd
to
18c7651
Compare
New changes are detected. LGTM label has been removed. |
/hold We have it as soon as update the OCP bundle to 4.15 |
18c7651
to
8c25d95
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to also update the e2e
test feature about memory config.. currently test is failing with the following:
checks (settings) # test/e2e/features/config.feature:9
When setting config property "memory" to value "9217" succeeds # test/e2e/features/config.feature:10
Error: command 'crc config set memory 9217', expected to succeed, exited with exit code: 1
With Openshift-4.15, OVN-K require extra 1.5G mem resource we need to increase that otherwise cluster doesn't comeup correctly.
Looks like with 4.15, free disk space is shrink by ~2G and node soon hit disk pressure during this test. In this PR disk size is increased to 40G to make sure following error doesn't happen during e2e. ``` Warning FailedScheduling 94s default-scheduler 0/1 nodes are available: 1 node(s) had untolerated taint {node.kubernetes.io/disk-pressure: }. preemption: 0/1 nodes are available: 1 Preemption is not helpful for scheduling.. ```
/retest |
@praveenkumar: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
With Openshift-4.15, OVN-K require extra 1.5G mem resource we need to increase that otherwise cluster doesn't comeup correctly.