WIP: Set pull-secret parameter not mandatory #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull secret is only required for openshift and microshift, this commit will remove the required policy on it checking to avoid adding a fake pull secret for okd. Also in case the preset requires the pull secret and it is not set the action will throw and error Signed-off-by: Adrian Riobo <[email protected]>
|
I think it is failing because now we are not passing the pull-secret for microshift which is required as part of this PR. |
|
No it is failing as it should be...cause I added a check step to show an error saying you need it...I had it as wip cause I want to add both cases on the gh action... one ensure it fails cause there is no ps.... and another one succeed. Once I have both I will remove WIP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull secret is only required for openshift and microshift, this commit will remove the required policy on it checking to avoid adding a fake pull secret for okd. Also in case the preset requires the pull secret and it is not set the action will throw and error