Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: updates state during extension startup #240

Merged
merged 2 commits into from
Jul 3, 2024
Merged

fix: updates state during extension startup #240

merged 2 commits into from
Jul 3, 2024

Conversation

dgolovin
Copy link
Contributor

@dgolovin dgolovin commented Jul 2, 2024

Fix #239.

@dgolovin dgolovin requested review from jeffmaury and lstocchi July 2, 2024 04:27
jeffmaury
jeffmaury requested changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are other parts of the code that check for this state, they should use this method now

@dgolovin dgolovin requested a review from jeffmaury July 2, 2024 16:00
jeffmaury
jeffmaury approved these changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgolovin dgolovin merged commit 6a58793 into crc-org:main Jul 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffmaury jeffmaury jeffmaury approved these changes

@lstocchi lstocchi Awaiting requested review from lstocchi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] CRC Provider dashboard card is in wrong state after crc cleanup
2 participants
@dgolovin @jeffmaury