Crc setup #17
Crc setup #17
Conversation
Signed-off-by: Yevhen Vydolob <[email protected]>
Signed-off-by: Yevhen Vydolob <[email protected]>
Signed-off-by: Yevhen Vydolob <[email protected]>
|
Several issues have been recorded that have mostly been worked around: #9 (comment) |
| connectToCrc(); | ||
| } | ||
|
|
||
| detectionChecks.push(...getCrcDetectionChecks(crcVersion)); | ||
|
|
||
| // create CRC provider | ||
| const provider = extensionApi.provider.createProvider({ | ||
| name: 'CRC', | ||
| name: productName, |
There was a problem hiding this comment.
Perhaps we should also offer a way to map the preset name with a clear Name and Description in a single file. (Improvement issue, low prio)
| statusFetchTimer = setInterval(async () => { | ||
| try { | ||
| // we don't need to update status while setup is going | ||
| if (isSetupGoing) { |
There was a problem hiding this comment.
Maybe indicate that setup is going? WDYT?
There was a problem hiding this comment.
Podman desktop doesn't have such state.
I add that, for case, when we perform setup before vm start, so user click start menu item, and we don't change extension state to starting until setup is not finished, which can take a while, so that indicate that we are starting, even if actual start is not going yet.
| try { | ||
| switch (crcStatus.Preset) { | ||
| case 'podman': | ||
| return 'Podman'; | ||
| case 'openshift': | ||
| return 'OpenShift'; | ||
| case 'microshift': | ||
| return 'MicroShift'; |
There was a problem hiding this comment.
Perhaps later, when the name is 'clearer', we have to extract this into a mapping to allow these names to be changed from a single file (or perhaps even provided from an API). Not to be changed now.
Signed-off-by: Yevhen Vydolob <[email protected]>
This PR call
crc setupafter installation. It provides basic process indication on status bar.During setup, user will be asked for preset.
Also PR adds detection that setup should be called, so
crc setupis called before vm stat.