Enable linux arm builds for admin-helper #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pr adds linux arm64 target to makefile and also make change to spec file to generate right package for arm64.
cfergeau
reviewed
Jun 19, 2024
crc-admin-helper.spec.in
Outdated
| @@ -29,6 +29,7 @@ Name: %{goname} | |||
| Release: 1%{?dist} | |||
| Summary: CRC's helper with administrative privileges | |||
| License: MIT | |||
| ExcludeArch: armv7hl i686 ppc64le s390x | |||
There was a problem hiding this comment.
I'd use ExclusiveArch rather than ExcludeArch http://ftp.rpm.org/max-rpm/s1-rpm-multi-platform-dependent-tags.html
We don't support all the arch so only build for supported one. - http://ftp.rpm.org/max-rpm/s1-rpm-multi-platform-dependent-tags.html
praveenkumar
force-pushed
the
enable_linux_arm
branch
from
dcd5489 to
ab3d2b6
Compare
cfergeau
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.