Play explanatory audios before hanging up #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If calls are not allowed they were simply hanged up, this is not very explanatory. Rejected calls will now play the sound defined under /sounds/vouncer_reject for said cases, this sound can explain to the user what happened.
If a call is allowed to go trough but it times out (far end rung but did not pick up) or the far end outright rejects it, a brief message is now played to explain the caller about the situation. The messge played is to be placed in /sounds/vouncer_timeout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of simply hanging up calls, vouncer will now play audio messages to explain the users why the call is being terminated.