Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript: Update project metadata file package.json before upload #25

Merged
merged 2 commits into from
May 30, 2024

Conversation

amotl
Copy link
Member

@amotl amotl commented May 30, 2024

About

A few more adjustments to package.json before upload, following up on GH-24.

Thoughts

I derived a few of those adjustments from the package.json file of crate-gc-admin. @alexdametto: Do you have any other suggestions? / Does it look sane?

@amotl amotl requested review from alexdametto and surister May 30, 2024 08:46
Copy link
Contributor

@alexdametto alexdametto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no suggestions. Good job. Maybe in the future it will be good to migrate it to typescript, but it's out of scope for now.
Let me know if you have any kind of problem by publishing on NPM, will be happy to help.

@amotl amotl merged commit a955e12 into main May 30, 2024
7 checks passed
@amotl amotl deleted the amo/js-packaging-adjustments branch May 30, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants