Bump bootstrap from 4.6.2 to 5.0.0 #852
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
|
I am hesitant merging this without manual verification that nothing goes south. Maybe you can have a quick look, @msbt? Please don't put in too many efforts fixing this, we can easily keep using Bootstrap 4, and this project's maintenance is offically on a hiatus. |
|
@dependabot recreate |
Bumps [bootstrap](https://github.com/twbs/bootstrap) from 4.6.2 to 5.0.0. - [Release notes](https://github.com/twbs/bootstrap/releases) - [Commits](twbs/bootstrap@v4.6.2...v5.0.0) --- updated-dependencies: - dependency-name: bootstrap dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/bootstrap-5.0.0
branch
from
b8db81f to
7ceab92
Compare
|
@amotl I went down the rabbithole to see what happens when we upgrade bootstrap and node (#863). Updating bootstrap and removing Is there any reason why dependabot was going with bootstrap 5.0 and not the latest, 5.3? So after my local changes and removing Footnotes |
|
Wow. Thanks. Yes, please submit your updates. According to your evaluations, I think we could consider merging them. Will you use a separate PR, eventually including individual commits from both this one (GH-852), and the other (GH-863)? We can still integrate them individually for separation of concerns, and then rebase your branch afterwards. However, for the time in flight/review, your PR would resemble an integration branch where everything should work well after modernizing those few bits? That would be well appreciated. /cc @kneth |
|
Update: This patch is incomplete. That other one intends to implement the update successfully. Thanks again, @msbt. |
|
Superseded by GH-864, closing. |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps bootstrap from 4.6.2 to 5.0.0.
Release notes
Sourced from bootstrap's releases.
... (truncated)
Commits
bf09367Release v5.0.0 (#33647)48ae5a7Rewrite migration guide (#33834)f086572refactor(docs): Added form file input variables (#33833)1a54286Fix doc typo and Bootstrap Icons link (#33832)e2df73fUpdate migration guide for some v5 changes (#33829)1e6356aNeutralise more words from placeholder text (#33731)6633845Bump eslint-config-xo from 0.35.0 to 0.36.0 (#33646)cb38744Tweak toast docs (#33810)c2ff225Bump rollup from 2.46.0 to 2.47.0 (#33818)c090ea2Bump@babel/preset-envfrom 7.14.0 to 7.14.1 (#33819)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.