Skip to content

Commit

Permalink
Add rpds to known_first_party for isort.
Browse files Browse the repository at this point in the history
I don't know why behavior differs between CI and locally (locally
nothing changes previously when running pre-commit, whereas in CI things
fail...). Maybe the actual name of the directory (which locally I have
called rpds.py) is what matters or something.

But I don't care to find out, this seems to explicitly make things work.
  • Loading branch information
Julian committed Jul 5, 2023
1 parent 3eeb532 commit 5de7a19
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 3 deletions.
1 change: 1 addition & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ combine_as_imports = true
from_first = true
include_trailing_comma = true
multi_line_output = 3
known_first_party = ["rpds"]

[tool.maturin]
features = ["pyo3/extension-module"]
3 changes: 2 additions & 1 deletion tests/test_hash_trie_map.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,10 @@
"""
from collections.abc import Hashable, Mapping

from rpds import HashTrieMap
import pytest

from rpds import HashTrieMap

HASH_MSG = "Not sure HashTrieMap implements Hash, it has mutable methods"


Expand Down
3 changes: 2 additions & 1 deletion tests/test_hash_trie_set.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,10 @@
FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
OTHER DEALINGS IN THE SOFTWARE.
"""
from rpds import HashTrieSet
import pytest

from rpds import HashTrieSet

HASH_MSG = "Not sure HashTrieSet implements Hash, it has mutable methods"


Expand Down
3 changes: 2 additions & 1 deletion tests/test_list.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,10 @@
FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
OTHER DEALINGS IN THE SOFTWARE.
"""
from rpds import List
import pytest

from rpds import List

HASH_MSG = "Not sure List implements Hash, it has mutable methods"


Expand Down

0 comments on commit 5de7a19

Please sign in to comment.