allow to limit source editing by user groups on per-field basis

src/Field.php

@@ -16,6 +16,7 @@
 use craft\elements\Asset;
 use craft\elements\Category;
 use craft\elements\Entry;
+use craft\elements\User;
 use craft\errors\InvalidHtmlTagException;
 use craft\helpers\ArrayHelper;
 use craft\helpers\Html;
@@ -146,6 +147,13 @@ public static function textPartLanguage(): array
      */
     public bool $enableSourceEditingForNonAdmins = false;
 
+    /**
+     * @var string|array|null User groups whose members should be able to edit the source even if they're not admin users
+     * if the $enableSourceEditingForNonAdmins is on.
+     * @since 3.11.0
+     */
+    public string|array|null $sourceEditingGroups = '*';
+
     /**
      * @var bool Whether to show volumes the user doesn’t have permission to view.
      * @since 1.2.0
@@ -234,6 +242,16 @@ public function getSettingsHtml(): ?string
     {
         $view = Craft::$app->getView();
 
+        $userGroupOptions = [];
+        foreach (Craft::$app->getUserGroups()->getAllGroups() as $group) {
+            if ($group->can('accessCp')) {
+                $userGroupOptions[] = [
+                    'label' => $group->name,
+                    'value' => $group->uid,
+                ];
+            }
+        }
+
         $volumeOptions = [];
         foreach (Craft::$app->getVolumes()->getAllVolumes() as $volume) {
             if ($volume->getFs()->hasUrls) {
@@ -254,6 +272,7 @@ public function getSettingsHtml(): ?string
 
         return $view->renderTemplate('ckeditor/_field-settings.twig', [
             'field' => $this,
+            'userGroupOptions' => $userGroupOptions,
             'purifierConfigOptions' => $this->configOptions('htmlpurifier'),
             'volumeOptions' => $volumeOptions,
             'transformOptions' => $transformOptions,
@@ -303,7 +322,7 @@ protected function inputHtml(mixed $value, ElementInterface $element = null): st
         // Toolbar cleanup
         $toolbar = array_merge($ckeConfig->toolbar);
 
-        if (!$this->enableSourceEditingForNonAdmins && !Craft::$app->getUser()->getIsAdmin()) {
+        if (!$this->isSourceEditingAllowed(Craft::$app->getUser()->getIdentity())) {
             ArrayHelper::removeValue($toolbar, 'sourceEditing');
         }
 
@@ -549,6 +568,35 @@ protected function prepValueForInput($value, ?ElementInterface $element): string
         return parent::prepValueForInput($value, $element);
     }
 
+    /**
+     * Returns if user belongs to a group whose members are allowed to edit source even if they're not admins
+     * @param User $user
+     * @return bool
+     */
+    private function isSourceEditingAllowed(User $user): bool
+    {
+        if ($user->admin) {
+            return true;
+        }
+
+        if (!$this->enableSourceEditingForNonAdmins) {
+            return false;
+        }
+
+        $allowedGroups = $this->sourceEditingGroups;
+        if ($allowedGroups === '*') {
+            return true;
+        }
+
+        if (is_string($allowedGroups)) {
+            $allowedGroups = [$allowedGroups];
+        }
+
+        $userGroups = array_keys(Collection::make($user->getGroups())->keyBy('uid')->all());
+
+        return !empty(array_intersect($allowedGroups, $userGroups));
+    }
+
     /**
      * @inheritdoc
      */

src/console/controllers/ConvertController.php

@@ -7,7 +7,6 @@
 
 namespace craft\ckeditor\console\controllers;
 
-use Composer\Util\Platform;
 use Craft;
 use craft\ckeditor\CkeConfig;
 use craft\ckeditor\CkeConfigs;

src/templates/_field-settings.twig

@@ -60,7 +60,21 @@
   name: 'enableSourceEditingForNonAdmins',
   label: 'Show the “Source” button for non-admin users?'|t('ckeditor'),
   on: field.enableSourceEditingForNonAdmins,
+  toggle: 'source-editing-groups'
 }) }}
+{% if userGroupOptions|length %}
+<div id="source-editing-groups">
+  {{ forms.checkboxSelectField({
+    id: 'sourceEditingGroups',
+    name: 'sourceEditingGroups',
+    label: 'Available User Groups'|t('ckeditor'),
+    instructions: 'The user groups whose members should see the “Source” button even if they’re not admins.'|t('ckeditor'),
+    options: userGroupOptions,
+    values: field.sourceEditingGroups,
+    showAllOption: userGroupOptions|length ? true : false
+  }) }}
+</div>
+{% endif %}
 
 <hr>
 

src/translations/en/ckeditor.php

@@ -2,6 +2,7 @@
 
 return [
     'Advanced' => 'Advanced',
+    'Available User Groups' => 'Available User Groups',
     'Available Transforms' => 'Available Transforms',
     'CKEditor Config' => 'CKEditor Config',
     'CKEditor Configs' => 'CKEditor Configs',
@@ -38,6 +39,7 @@
     'The default transform that should be applied when inserting an image.' => 'The default transform that should be applied when inserting an image.',
     'The transforms that should be available when inserting images.' => 'The transforms that should be available when inserting images.',
     'The type of column this field should get in the database.' => 'The type of column this field should get in the database.',
+    'The user groups whose members should see the “Source” button even if they’re not admins.' => 'The user groups whose members should see the “Source” button even if they’re not admins.',
     'Toolbar' => 'Toolbar',
     'View available settings' => 'View available settings',
     'Word Limit' => 'Word Limit',