Skip to content

Commit

Permalink
(#135) Added schema location to metric.xml
Browse files Browse the repository at this point in the history
As per ARC review:
* Left puzzle for further refactor towards simpler solution
  • Loading branch information
llorllale committed Feb 27, 2018
1 parent 63c7147 commit 752b4d5
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions src/main/java/org/jpeek/Report.java
Original file line number Diff line number Diff line change
Expand Up @@ -139,11 +139,11 @@ final class Report {
* @param mean Mean
* @param sigma Sigma
* @checkstyle ParameterNumberCheck (10 lines)
* @todo #135:30min Make Report save 'metric.xsd' itself. Currently, Report
* is setting the schema's location on the output metric XML based on the
* assumption that App will always save it to a relative subdirectory
* 'xsd' and with the same filename 'metric.xsd'. This promise is best
* kept if Report class has the responsibility of saving metric.xsd itself.
* @todo #135:30min The current solution to add the reference to
* 'metric.xsd' in the generated 'metric.xml' is too complex for
* the task at hand. Refactor towards a simpler solution that
* ideally would just require one or two Xembly instructions to
* add the required attribute.
*/
@SuppressWarnings("unchecked")
Report(final XML xml, final String name,
Expand Down

4 comments on commit 752b4d5

@0pdd
Copy link
Collaborator

@0pdd 0pdd commented on 752b4d5 Feb 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puzzle 135-d5b2c3f6 discovered in src/main/resources/org/jpeek/xsd/skeleton.xsd and submitted as #224. Please, remember that the puzzle was not necessarily added in this particular commit. Maybe it was added earlier, but we discovered it only now.

@0pdd
Copy link
Collaborator

@0pdd 0pdd commented on 752b4d5 Feb 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puzzle 135-9cabe027 discovered in src/main/resources/org/jpeek/xsd/matrix.xsd and submitted as #225. Please, remember that the puzzle was not necessarily added in this particular commit. Maybe it was added earlier, but we discovered it only now.

@0pdd
Copy link
Collaborator

@0pdd 0pdd commented on 752b4d5 Feb 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puzzle 135-4462c34d discovered in src/main/resources/org/jpeek/xsd/index.xsd and submitted as #226. Please, remember that the puzzle was not necessarily added in this particular commit. Maybe it was added earlier, but we discovered it only now.

@0pdd
Copy link
Collaborator

@0pdd 0pdd commented on 752b4d5 Feb 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puzzle 135-1c80191e discovered in src/main/java/org/jpeek/Report.java and submitted as #227. Please, remember that the puzzle was not necessarily added in this particular commit. Maybe it was added earlier, but we discovered it only now.

Please sign in to comment.