Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Chakra V3 Upgrade #1438

Open
wants to merge 81 commits into
base: master
Choose a base branch
from
Open

feat(ui): Chakra V3 Upgrade #1438

wants to merge 81 commits into from

Conversation

asharonbaltazar
Copy link
Collaborator

Move Chakra from V2 to V3

  • updates to theming logic (recipes, slotRecipes)
  • move to compositional UI logic
  • many, many import path updates
  • minor updates to stylesheets when applicable
  • update ContextMenu logic to use new Chakra MenuContextTrigger
  • update all icons to use react-icons/iconLib and remove @react-icons

Known Issues ⚠️
Some positioning issues with absolute icons in the EventEditor
Screenshot 2025-01-06 at 8 12 15 PM

Chakra removed the AlertDialog component
Screenshot 2025-01-06 at 8 12 46 PM

Event title is visible through tooltip content
Screenshot 2025-01-06 at 8 13 26 PM

Close button is slightly smaller
Screenshot 2025-01-06 at 8 14 12 PM

There could be other issues with components I had not been able to test due to my limited knowledge around the app

@alex-Arc
Copy link
Collaborator

alex-Arc commented Jan 7, 2025

Ah ok

Navigate to the apps/client/src/theme dir and run this in the terminal:

could this be part of a post install script or something like this

{
  "scripts": {
    "typegen:theme":"npx @chakra-ui/cli typegen src/theme/theme.ts",
    "postinstall": "pnpm addversion && pnpm typegen:theme",
 }
}

also @chakra-ui/cli will have to be a devDependencies

@asharonbaltazar
Copy link
Collaborator Author

It's already been done! Should work if you run pnpm typegen in apps/client

@cpvalente cpvalente added the priority Issue or PR to be prioritised label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority Issue or PR to be prioritised
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants