-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce code duplication in 32 bit types #858
Conversation
Uses techniques from #857 to speed things way up. Current develop:
with this PR:
|
46b9df9
to
f091a0a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #858 +/- ##
=========================================
+ Coverage 98.8% 98.9% +0.1%
=========================================
Files 232 233 +1
Lines 16827 16824 -3
Branches 1813 1817 +4
=========================================
Hits 16625 16625
+ Misses 202 199 -3
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Adds a method for one shot decoding and completely removes the subtraction implementation as we can just use a - b = a + (-b)