Skip to content

Commit

Permalink
ci: Upgrade upload-artifact action to v4 (#2376)
Browse files Browse the repository at this point in the history
`upload-artifact` v3 has been deprecated for a while now and Github
Actions prevent its use now by automatically failing any job using it.

Besides upgrading to the latest major version of the action, we add a
compression level option that should better suit our needs (i.e. large
files not easily compressed).
See
https://github.com/actions/upload-artifact/tree/v4.6.1?tab=readme-ov-file#usage
  • Loading branch information
taratatach authored Feb 28, 2025
2 parents 756cb9b + 3d17fa9 commit 775467f
Show file tree
Hide file tree
Showing 4 changed files with 100 additions and 309 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/linux.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -241,10 +241,11 @@ jobs:
gh-token: "${{ secrets.GITHUB_TOKEN }}"
- name: Save artifacts
if: ${{ github.event_name == 'pull_request' }}
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: Binaries
path: |
${{ github.workspace }}/dist/latest-linux.yml
${{ github.workspace }}/dist/Cozy[- ]Drive[- ]*.AppImage
retention-days: 5
compression-level: 0
3 changes: 2 additions & 1 deletion .github/workflows/macos.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -313,11 +313,12 @@ jobs:
apple-team-id: "${{ secrets.apple_team_id }}"
- name: Save artifacts
if: ${{ github.event_name == 'pull_request' }}
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: Binaries
path: |
${{ github.workspace }}/dist/latest-mac.yml
${{ github.workspace }}/dist/Cozy[- ]Drive[- ]*.dmg
${{ github.workspace }}/dist/Cozy[- ]Drive[- ]*-mac.zip
retention-days: 5
compression-level: 0
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -153,9 +153,9 @@
"electron-builder": "^24",
"electron-download": "^4.1.1",
"electron-mocha": "^13.0.0",
"elm": "^0.19.1",
"elm": "^0.19.1-6",
"elm-format": "0.8.5",
"elm-test": "^0.19.1",
"elm-test": "^0.19.1-revision15",
"elm-upgrade": "0.19.8",
"env-cmd": "10.1.0",
"eslint": "^8.0.0",
Expand Down
Loading

0 comments on commit 775467f

Please sign in to comment.