fix: fix canonical path for OSS4 signature

cozy-elixir · Jul 16, 2024 · 9f90f2b · 9f90f2b
1 parent 203e5a1
commit 9f90f2b
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/examples/file_store.ex b/examples/file_store.ex
@@ -11,7 +11,7 @@ defmodule FileStore do
     request =
       build_request(
         method: :put,
-        path: Path.join("/", key),
+        path: URI.encode(Path.join("/", key)),
         body: data
       )
 
@@ -30,7 +30,7 @@ defmodule FileStore do
     request =
       build_request(
         method: :get,
-        path: Path.join("/", key)
+        path: URI.encode(Path.join("/", key))
       )
 
     opts = build_opts(sign_type: :header)
@@ -48,7 +48,7 @@ defmodule FileStore do
     request =
       build_request(
         method: :delete,
-        path: Path.join("/", key)
+        path: URI.encode(Path.join("/", key))
       )
 
     opts = build_opts(sign_type: :header)
@@ -66,7 +66,7 @@ defmodule FileStore do
     request =
       build_request(
         method: :get,
-        path: Path.join("/", key),
+        path: URI.encode(Path.join("/", key)),
         query: "x-oss-expires=300"
       )
 

diff --git a/lib/alibaba_cloud_kit/signature/oss4.ex b/lib/alibaba_cloud_kit/signature/oss4.ex
@@ -384,8 +384,8 @@ defmodule AlibabaCloudKit.Signature.OSS4 do
     path = request.path
 
     if(bucket,
-      do: "/#{bucket}#{path}",
-      else: path
+      do: "/#{bucket}#{URI.decode(path)}",
+      else: URI.decode(path)
     )
     |> URI.encode()
   end

diff --git a/test/examples/file_store_test.exs b/test/examples/file_store_test.exs
@@ -18,7 +18,7 @@ defmodule FileStoreTest do
 
   @tag external: true
   test "manage files" do
-    key = "examples/file_store/temporary/lenna.png"
+    key = "examples/file_store/temporary/lenna woman.png"
     assert {:ok, _key} = FileStore.put_file(key, @example_image_binary)
     assert {:ok, _data} = FileStore.get_file(key)
     assert {:ok, _key} = FileStore.delete_file(key)
@@ -27,7 +27,7 @@ defmodule FileStoreTest do
 
   @tag external: true
   test "generates a signed URL which can be accessed in Web browser" do
-    key = "examples/file_store/persistent/lenna.png"
+    key = "examples/file_store/persistent/lenna woman.png"
     {:ok, key} = FileStore.put_file(key, @example_image_binary)
     url = FileStore.get_access_url(key)
     assert {:ok, %{status: 200}} = Tesla.get(url)
@@ -37,7 +37,7 @@ defmodule FileStoreTest do
   test "presigns a file and uploading a file with related information" do
     alias Tesla.Multipart
 
-    key = "examples/file_store/presign/lenna.png"
+    key = "examples/file_store/presign/lenna woman.png"
 
     %{
       endpoint: endpoint,
@@ -66,7 +66,7 @@ defmodule FileStoreTest do
   test "presigns a file with OSS v1 signature and uploading a file with related information" do
     alias Tesla.Multipart
 
-    key = "examples/file_store/presign_v1/lenna.png"
+    key = "examples/file_store/presign_v1/lenna woman.png"
 
     %{
       endpoint: endpoint,