testing SbtCoursierCache leak #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
however if I revert the fix the test is still green. I added a few printlns and can see that the SbtCoursierCache instance after the clean is different. Does this happen because of the reload in a scripted test is different? or maybe the problem I reported only manifest in more complex scenarios?
I'd lean on the former. The scripted tests are run with sbt Let's add this test anyway, it'll be helpful when we bump the sbt version. |
ok let me just revert the other changes |
alexarchambault
approved these changes
Feb 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
however if I revert the fix the test is still green.
I added a few printlns and can see that the SbtCoursierCache
instance after the reload is different.
Does this happen because of the reload in a scripted test is
different? or maybe the problem I reported only manifest in
more complex scenarios?