Fix Oracle JDK index generation #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please @ckipp01 / @alexarchambault ... if you can take a look as this messes up with the |
ckipp01
approved these changes
Mar 19, 2024
|
Thanks! Yeah... since there is no docs, it would be nice to have some validation. |
ckipp01
added a commit
to ckipp01/jvm-index
that referenced
this pull request
Mar 21, 2024
This is sort of a proposal. Following the comment in coursier#243 (comment) by @carlosedp I was going to try and write some docs on the actual structure of the index, but right away hit on the fact that it's just this: ``` final case class Index(map: Map[String, Map[String, Map[String, Map[String, String]]]]) { ``` It's pretty impossible to know what these `String`s all are so I figured maybe it'd be good to start just typing this out a bit more. I used an opaque type for `Os` here in hopes that it'd make things clearer a bit throughout the code, and figured we could do that for all the `String`s in the `Index`, but wanted to see what it would be like to at least do one of them first. Thoughts on this?
alexarchambault
pushed a commit
that referenced
this pull request
Jul 24, 2024
This is sort of a proposal. Following the comment in #243 (comment) by @carlosedp I was going to try and write some docs on the actual structure of the index, but right away hit on the fact that it's just this: ``` final case class Index(map: Map[String, Map[String, Map[String, Map[String, String]]]]) { ``` It's pretty impossible to know what these `String`s all are so I figured maybe it'd be good to start just typing this out a bit more. I used an opaque type for `Os` here in hopes that it'd make things clearer a bit throughout the code, and figured we could do that for all the `String`s in the `Index`, but wanted to see what it would be like to at least do one of them first. Thoughts on this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found the issue that led to coursier/coursier#2952.
The Oracle index currently generates:
{ "graalvm-jdk@oracle": { "17": "https://download.oracle.com/graalvm/17/latest/graalvm-jdk-17_macos-x64_bin.tar.gz", "21": "https://download.oracle.com/graalvm/21/latest/graalvm-jdk-21_macos-x64_bin.tar.gz"While the correct way is as now:
{ "jdk@graalvm-oracle": { "17": "tgz+https://download.oracle.com/graalvm/17/latest/graalvm-jdk-17_macos-x64_bin.tar.gz", "21": "tgz+https://download.oracle.com/graalvm/21/latest/graalvm-jdk-21_macos-x64_bin.tar.gz" }, "jdk@java-oracle": { "17": "tgz+https://download.oracle.com/java/17/latest/jdk-17_macos-x64_bin.tar.gz", "21": "tgz+https://download.oracle.com/java/21/latest/jdk-21_macos-x64_bin.tar.gz" } ...Sorry about the hassle.