Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sanitize gov v1 proposal in e2e tests for compatibility with 0.52 #7861

Merged
merged 5 commits into from
Jan 22, 2025

Conversation

gjermundgaraba
Copy link
Contributor

Description

Closes #7844

I will run the compatibility tests with this branch before merging.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@gjermundgaraba
Copy link
Contributor Author

I've confirmed that the compatibility tests seem to mostly work OK now.
There are a few tests that are still failing, but it is not obvious that this is related to the 0.52 upgrade, so I pulled those out to a separate issue, so we can close this:
#7864

}
return msg
}

func replaceCometBFTValidatorV1(validator *cmtproto.Validator) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe mutate or convert instead of replace. since i expected this to be returning a new type rather than mutating in-place

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! Done!

Copy link

@gjermundgaraba gjermundgaraba added this pull request to the merge queue Jan 22, 2025
Merged via the queue into main with commit 39b190a Jan 22, 2025
70 of 71 checks passed
@gjermundgaraba gjermundgaraba deleted the gjermund/fix-compatibility-tests-052 branch January 22, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix e2e compatibility tests for 0.52
2 participants