-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: Speedup key formatting #864
Conversation
WalkthroughThe update presents a shift to a more efficient prefixing system within a key formatting package, adjusting key generation and indexing methodologies. It also includes renaming of certain struct fields for clarity and aligns with a new versioning scheme. The changes streamline the process of key manipulation, specifically for benchmarks, and affect how nodes are referenced and stored within the database. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ? TipsChat with CodeRabbit Bot (
|
// Legacy: LeftNodeHash | ||
// v1: Left node ptr via Version/key | ||
leftNodeKey []byte | ||
// Legacy: RightNodeHash | ||
// v1: Right node ptr via Version/key |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Driveby comment addition
This speeds up key formatting, which is by no means the bottleneck, but appeared to be 0.5% of the time of some Osmosis mainnet sync pprof's on IAVL v0 and v1