Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client/v2): add map support (backport #23544) #23554

Merged
merged 3 commits into from
Jan 29, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 29, 2025

Description

Follow-up of #23539


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:

  • confirmed ! in the type prefix if API or client breaking change

  • targeted the correct branch (see PR Targeting)

  • provided a link to the relevant issue or specification

  • reviewed "Files changed" and left comments if necessary

  • included the necessary unit and integration tests

  • added a changelog entry to CHANGELOG.md

  • updated the relevant documentation or specification, including comments for documenting Go code

  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • New Features

    • Added support for maps in queries for autocli
  • Dependency Updates

    • Updated cosmossdk.io/x/tx from v1.0.1 to v1.1.0 across multiple modules
  • Documentation

    • Updated changelog for x/tx module to version v0.13.8
    • Improved formatting in client/v2/CHANGELOG.md

This is an automatic backport of pull request #23544 done by [Mergify](https://mergify.com).

(cherry picked from commit d8ea6a9)

# Conflicts:
#	client/v2/CHANGELOG.md
#	client/v2/go.mod
#	client/v2/go.sum
#	simapp/go.sum
#	simapp/v2/go.mod
#	tests/go.mod
#	tests/go.sum
#	x/feegrant/go.mod
#	x/feegrant/go.sum
#	x/gov/go.mod
#	x/gov/go.sum
#	x/group/go.mod
#	x/group/go.sum
#	x/tx/CHANGELOG.md
#	x/upgrade/go.mod
#	x/upgrade/go.sum
Copy link
Contributor Author

mergify bot commented Jan 29, 2025

Cherry-pick of d8ea6a9 has failed:

On branch mergify/bp/release/v0.50.x/pr-23544
Your branch is up to date with 'origin/release/v0.50.x'.

You are currently cherry-picking commit d8ea6a952.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   client/v2/autocli/query.go

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   client/v2/CHANGELOG.md
	both modified:   client/v2/go.mod
	both modified:   client/v2/go.sum
	both modified:   simapp/go.sum
	deleted by us:   simapp/v2/go.mod
	both modified:   tests/go.mod
	both modified:   tests/go.sum
	both modified:   x/feegrant/go.mod
	both modified:   x/feegrant/go.sum
	deleted by us:   x/gov/go.mod
	deleted by us:   x/gov/go.sum
	deleted by us:   x/group/go.mod
	deleted by us:   x/group/go.sum
	both modified:   x/tx/CHANGELOG.md
	both modified:   x/upgrade/go.mod
	both modified:   x/upgrade/go.sum

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix

@julienrbrt julienrbrt enabled auto-merge (squash) January 29, 2025 17:24
@julienrbrt julienrbrt merged commit 5f08d21 into release/v0.50.x Jan 29, 2025
46 of 48 checks passed
@julienrbrt julienrbrt deleted the mergify/bp/release/v0.50.x/pr-23544 branch January 29, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant