fix(server/v2): inject latest height when not provide in grpc query #23483
Conversation
📝 WalkthroughWalkthroughThe pull request modifies the Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
github-actions
bot
added
C:server/v2
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
server/v2/cometbft/abci.go (1)
187-191: Consider adding error handling for gRPC response.While the placement is correct, we should handle potential errors in the gRPC response before proceeding with other query paths.
resp, isGRPC, err := c.maybeRunGRPCQuery(ctx, req) if isGRPC { + if err != nil { + return queryResult(err, c.cfg.AppTomlConfig.Trace), nil + } return resp, err }Also applies to: 192-224
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
server/v2/cometbft/abci.go(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
server/v2/cometbft/abci.go (1)
Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: tests (00)
- GitHub Check: test-simapp-v2
- GitHub Check: test-system-v2
- GitHub Check: Analyze
- GitHub Check: build (amd64)
- GitHub Check: Summary
🔇 Additional comments (2)
server/v2/cometbft/abci.go (2)
187-191: LGTM! The placement of maybeRunGRPCQuery is correct.Moving the gRPC query handling before other logic ensures that gRPC queries get the latest height injection benefit.
187-191: Verify error handling in upstream gRPC clients.The change in query height injection behavior might affect upstream clients that explicitly set height to 0 expecting different behavior.
Also applies to: 192-224
✅ Verification successful
No evidence of upstream gRPC clients relying on height=0 behavior
After thorough analysis of the codebase, no actual gRPC client implementations were found that explicitly set height to 0 or use WithHeight(0). The only height=0 usage found is in app export functionality, which is unrelated to gRPC queries.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for gRPC client code that might be affected by the height injection change rg -l 'WithHeight\(0\)' || rg -l '\.Height\s*=\s*0'Length of output: 1168
Script:
#!/bin/bash # Search for actual client usage of height=0 in queries # Exclude generated files and focus on test/client code rg -g '!*.pb.go' -g '!*.pulsar.go' 'WithHeight\(0\)|\.Height\s*=\s*0' -A 3 -B 3Length of output: 369
There was a problem hiding this comment.
Ok, i see, appmanager was supposed to do it:
cosmos-sdk/server/v2/appmanager/appmanager.go
Line 267 in 3860b2b
resp.Height was left not updated.
Description
Closes: #23481
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
The changes focus on internal query processing mechanics without altering the core functionality or public interfaces of the system.