Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix runtime doc dead link to app-go-di.md #23264

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

BabyHalimao
Copy link
Contributor

@BabyHalimao BabyHalimao commented Jan 9, 2025

app-go-di file name is 01-app-go-di.md, not 02-app-go-di.md

Summary by CodeRabbit

  • Documentation
    • Updated documentation reference link for the runtime package section
    • Corrected navigation path in the "More information on building applications" paragraph

@BabyHalimao BabyHalimao requested a review from a team as a code owner January 9, 2025 03:39
Copy link
Contributor

coderabbitai bot commented Jan 9, 2025

📝 Walkthrough

Walkthrough

The pull request introduces a minor documentation update in the Cosmos SDK's runtime package documentation. Specifically, it corrects a navigation reference link from ./02-app-go-di.md to ./01-app-go-di.md in the docs/build/building-apps/00-runtime.md file. This change ensures accurate internal documentation linking without modifying any code functionality.

Changes

File Change Summary
docs/build/building-apps/00-runtime.md Updated internal documentation link reference

Suggested labels

T:Docs

Suggested reviewers

  • julienrbrt
  • tac0turtle

Possibly related PRs


📜 Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 39a55ed and 1f83ef2.

📒 Files selected for processing (1)
  • docs/build/building-apps/00-runtime.md (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • docs/build/building-apps/00-runtime.md
⏰ Context from checks skipped due to timeout of 90000ms (5)
  • GitHub Check: build (arm64)
  • GitHub Check: build (amd64)
  • GitHub Check: dependency-review
  • GitHub Check: markdown-link-check
  • GitHub Check: Summary

Finishing Touches

  • 📝 Generate Docstrings

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@julienrbrt julienrbrt added the backport/v0.52.x PR scheduled for inclusion in the v0.52's next stable release label Jan 9, 2025
@julienrbrt julienrbrt enabled auto-merge January 9, 2025 08:17
@julienrbrt julienrbrt added this pull request to the merge queue Jan 9, 2025
Merged via the queue into cosmos:main with commit 60e8c6a Jan 9, 2025
70 of 74 checks passed
mergify bot pushed a commit that referenced this pull request Jan 9, 2025
@BabyHalimao BabyHalimao deleted the fix/app-go-di-link branch January 9, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.52.x PR scheduled for inclusion in the v0.52's next stable release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants