Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(x/upgrade): register missing implementation for SoftwareUpgradeProposal #23179

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(x/upgrade): register missing implementation for SoftwareUpgradeProposal #23179

wants to merge 3 commits into from
+44 −4

Conversation

mmsqe
Copy link
Contributor

@mmsqe mmsqe commented Jan 4, 2025

to avoid no concrete type registered for type URL /cosmos.upgrade.v1beta1.SoftwareUpgradeProposal against interface *v1beta1.Content error

Description

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@mmsqe
fix(x/upgrade): register missing implementation for SoftwareUpgradePr…
61fafb4 
…oposal

to avoid no concrete type registered
for type URL /cosmos.upgrade.v1beta1.SoftwareUpgradeProposal against interface *v1beta1.Content error
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 4, 2025 •
edited
Loading

Warning

Rate limit exceeded

@mmsqe has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 44 minutes and 25 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between b0031a1 and 0a08e76.

📒 Files selected for processing (4)
  • CHANGELOG.md (1 hunks)
  • UPGRADING.md (1 hunks)
  • x/upgrade/types/codec.go (2 hunks)
  • x/upgrade/types/proposal.go (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@tac0turtle
Copy link
Member

with messages in gov v1, there shouldnt be a need for this.

@mmsqe
Copy link
Contributor Author

mmsqe commented Jan 5, 2025

with messages in gov v1, there shouldnt be a need for this.

not sure but I need register this when using tx upgrade

@julienrbrt
Copy link
Member

with messages in gov v1, there shouldnt be a need for this.

not sure but I need register this when using tx upgrade

Very weird, tx upgrade uses gov v1:

cosmos-sdk/x/upgrade/client/cli/tx.go

Line 108 in 787a713

if err := proposal.SetMsgs([]sdk.Msg{

Are you submitting a legacy upgrade proposal and then querying it on the updated binary?

@mmsqe
Copy link
Contributor Author

mmsqe commented Jan 6, 2025 •
edited
Loading

Are you submitting a legacy upgrade proposal and then querying it on the updated binary?

Upgrade is from sdk50 binary to sdk52 using ethermintd tx upgrade software-upgrade sdk52 -y --no-validate --from community --title 'upgrade test' --note ditto --upgrade-height 48 --summary summary --deposit 10000aphoton

@mmsqe mmsqe marked this pull request as ready for review January 8, 2025 02:10
mmsqe
mmsqe commented Jan 8, 2025
View reviewed changes
x/upgrade/types/codec.go
registrar.RegisterImplementations(
(*v1beta1.Content)(nil),
&SoftwareUpgradeProposal{},
)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
)
)
registrar.RegisterImplementations(
(*v1beta1.Content)(nil),
&CancelSoftwareUpgradeProposal{},
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facundomedica facundomedica Awaiting requested review from facundomedica facundomedica is a code owner

@cool-develope cool-develope Awaiting requested review from cool-develope cool-develope is a code owner

@akhilkumarpilli akhilkumarpilli Awaiting requested review from akhilkumarpilli akhilkumarpilli is a code owner

@lucaslopezf lucaslopezf Awaiting requested review from lucaslopezf lucaslopezf is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
C:x/upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmsqe @tac0turtle @julienrbrt