cosmrs: PublicKey JSON serialization support
#133
Merged
+173
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tony-iqlusion
commented
Sep 29, 2021
Comment on lines
+21
to
+22
| serde = { version = "1", features = ["serde_derive"] } | ||
| serde_json = "1" |
There was a problem hiding this comment.
These are already transitive hard dependencies, so no point in making them optional
Adds support for the "Cosmos JSON" `PublicKey` serialization, e.g.:
{"@type":"/cosmos.crypto.ed25519.PubKey","key":"sEEsVGkXvyewKLWMJbHVDRkBoerW0IIwmj1rHkabtHU="}
Encoding follows Protobub JSON conventions, with binary data encoded as
standard (i.e. non-URL safe) Base64. However, note that it's
structurally still a bit different from the Protobuf JSON encoding for
public keys, and thus entails a custom solution.
Also note that there is unfortunately not yet a general solution for
Protobuf JSON encoding for `prost::Message`:
tokio-rs/prost#75
tony-iqlusion
force-pushed
the
tony-iqlusion/public-key-json
branch
from
ddc5f53 to
d06935e
Compare
zmanian
approved these changes
Sep 29, 2021
This was referenced Oct 4, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the "Cosmos JSON"
PublicKeyserialization, e.g.:Encoding follows Protobub JSON conventions, with binary data encoded as standard (i.e. non-URL safe) Base64. However, note that it's structurally still a bit different from the Protobuf JSON encoding for public keys, and thus entails a custom solution.
Also note that there is unfortunately not yet a general solution for Protobuf JSON encoding for
prost::Message:tokio-rs/prost#75