Support EncodeObj #129
Closed
Support EncodeObj #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
webmaster128
reviewed
Jun 5, 2023
| } | ||
| })(); | ||
|
|
||
| const msg: EncodeObject = { typeUrl: msgTypeUrl, value: parsedMsgValue }; |
There was a problem hiding this comment.
The value: parsedMsgValue here is the tricky part: here we need the telescope-specific format. E.g. 64bit integers need to be represented as a Long type. Binary data needs to be Uint8Array. There is no standardized way to get this from JSON without message specific JSON -> JavaScript importers.
abefernan
requested review from
webmaster128
and removed request for
webmaster128
|
Implementation not valid, will keep exploring in #29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #29.