fix Num multiplication, add Real, Enum, Integral instances #67
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These instances are based on using the nanosecond as the underlying unit, i.e. the value of a TimeSpec is the integer
s * 1e9 + ns
.Before it was based on representing the rational
s + (ns / 1e9)
. But the integer valuation satisfies the ring laws and provides much more intuitive behavior, e.g.Before, this gave 0.
This should properly fix #32, #33. Of course it breaks anyone who was using the old version of
(*)
. The old version of(*)
is equivalent toa * b `div` 1000000000
in the new version.