Allow extra Clock constructors in clockToConst #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My Mac (10.14) has `CLOCK_MONOTONIC_RAW` defined: ``` Prelude> import System.Clock Prelude System.Clock> :info Clock data Clock = Monotonic | Realtime | ProcessCPUTime | ThreadCPUTime | MonotonicRaw ``` Which then errors in `clockToConst` if `MonotonicRaw` is passed. The logic for clockToConst should follow the same logic as the Clock constructor; that is, don't put the CLOCK_MONOTONIC_RAW/CLOCK_BOOTTIME/etc. within the Linux else-block, but only check the relevant C++ flags.
|
@brandon-leapyear do I understand correctly that this means https://bugs.python.org/issue35716 - mentions |
|
✨ This is an old work account. Please reference @brandonchinn178 for all future communication ✨ ^ I guess there it is. It's strange though; the man page says only Linux, but I've found a few other places that recognize Mac: |
|
They are all system-specific. MacOS has some more that are not present on GNU/Linux. |
|
@brandon-leapyear new enough macs have it, OS X prior to (macOS 10.12) DO NOT have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ This is an old work account. Please reference @brandonchinn178 for all future communication ✨
My Mac (10.14) has
CLOCK_MONOTONIC_RAWdefined, as evidenced by theClockconstructor:Which then errors in
clockToConstifMonotonicRawis passed. The logic for clockToConst should follow the same logic as the Clock constructor; that is, don't put the CLOCK_MONOTONIC_RAW/CLOCK_BOOTTIME/etc. within the Linux else-block, but only check the relevant C++ flags.