feat: participation streak templates #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LomyW
suggested changes
Jan 25, 2024
dhenkel92
reviewed
Feb 2, 2024
Comment on lines
+192
to
+195
| await prisma.user_achievement.update({ | ||
| where: { id: userAchievements[currentAchievementIndex].id }, | ||
| data: { achievedAt: null, isSeen: false }, | ||
| }); |
There was a problem hiding this comment.
I don't think that this belongs here.
It would mean that we have an invalid state for some reason, which shouldn't be fixed while assembling data.
When does it happen?
There was a problem hiding this comment.
Imagine you have a streak of 25 consecutive meetings joined.
Now you do not join any more meetings. You do not fire any more events "match_meeting_joined" or what ever the action name is.
The streak would never be resolved into being 0 because we never reevaluate. We offered a cronjob, that was already implemented, but that was not wanted either. So we have to update streaks here.
dhenkel92
approved these changes
Feb 9, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: https://github.com/corona-school/project-user/issues/1100
closes: https://github.com/corona-school/project-user/issues/1099
What was done: