feat: Exclude existing pupils from requiring a screening #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use matches / course participation to exlude existing active pupils from needing a screening
realmayus
approved these changes
Jan 22, 2024
|
@realmayus that was my initial plan, but it also comes with the downside that then we have thousands of "fake screenings", i.e. it would mess up our screening statistics for example, and screeners would be confused by "previous successful screenings". Additionally there might be edge cases where this might actually be desired, i.e. Plus Pupils that are manually matched are then also allowed to access the user app without having been screened |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use matches / course participation to exlude existing active pupils from needing a screening