Fix and amend statistics #959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- count registrations of helpers/pupils (instead of just tutors/tutees) - consider both screenings and instructor_screenings in `helperScreenings` endpoint - `nowFirstMatchesStudent` now considers all students that had their first match in a certain month; not just students that only have a single match - `nowDissolvedMatchesAfter/BeforeThreeMonths` now considers dissolvedAt instead of updatedAt - add category controls to `offeredLectures` and `numSubcourses` - consider start date of first lecture for `numSubcourses`, only consider courses that are allowed - consider start date of lectures instead of creation date in `offeredLectures`, only consider group type appointments - split `rateSuccessfulCoCs` into tutor and instructor endpoints - rate of successful CoCs is now calculated differently: out of all tutors that must have turned in their CoC (max 8 weeks after screening) within the selected timeframe, how many actually did it? - compute trends for dissolved matches (cannot do that in retool as selected timeframe may not align with a specific month) - `matchesByDuration` now counts the matches that were created after `statistics.from` and dissolved after `statistics.to` - add `helpersWithoutScreening` metric for determining number of helpers that were invited for a screening - add `medianTimeToMatch` to provide a better estimate; do this for both students and pupils (used in retool and perhaps in match request form in user app later down the road)
…as data is nonsense, remove rateTutorFirstMatchStillActiveAfterOneMonth as it's no longer needed
Jonasdoubleyou
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
helperScreeningsendpointnowFirstMatchesStudentnow considers all students that had their first match in a certain month; not just students that only had a single match which happens to be in that monthnowDissolvedMatchesAfter/BeforeThreeMonthsnow considersdissolvedAtinstead ofupdatedAtofferedLecturesandnumSubcoursesnumSubcourses, only consider courses that are allowedofferedLectures, only consider group type appointmentsrateSuccessfulCoCsinto tutor and instructor endpointsmatchesByDurationnow counts the matches that were created afterstatistics.fromand dissolved beforestatistics.tohelpersWithoutScreeningmetric for determining number of helpers that were invited for a screeningmedianTimeToMatchto provide a better estimate; do this for both students and pupils (used in retool and perhaps in match request form in user app later down the road)