Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: achievement integration tests #956

Merged
merged 16 commits into from
Jan 25, 2024
Merged

feat: achievement integration tests #956

merged 16 commits into from
Jan 25, 2024

Conversation

LucasFalkowsky
Copy link
Contributor

closes https://github.com/corona-school/project-user/issues/1034

What was done

  1. tests for sequential achievements for students and pupils
  2. tests for tiered achievements for students and pupils
  3. tests for streak achievements for students and pupils
  4. test for all achievements resolver
  5. test for further achievements resolver
  6. test for next step achievements resolver
  7. test for achievement by id resolver

@LucasFalkowsky LucasFalkowsky requested a review from LomyW January 19, 2024 08:36
@realmayus realmayus temporarily deployed to backend-feat-1034-achie-izhg5x January 19, 2024 08:37 Inactive
@LomyW LomyW requested a review from dhenkel92 January 19, 2024 08:38
@realmayus realmayus had a problem deploying to backend-feat-1034-achie-izhg5x January 19, 2024 09:16 Failure
@realmayus realmayus temporarily deployed to backend-feat-1034-achie-izhg5x January 19, 2024 09:17 Inactive
@dhenkel92 dhenkel92 temporarily deployed to backend-feat-1034-achie-izhg5x January 20, 2024 11:15 Inactive
@dhenkel92 dhenkel92 temporarily deployed to backend-feat-1034-achie-izhg5x January 20, 2024 11:24 Inactive
@dhenkel92 dhenkel92 force-pushed the feat/1034-achievement-integration-tests branch from 1dc7733 to 68fde20 Compare January 20, 2024 11:25
@dhenkel92 dhenkel92 temporarily deployed to backend-feat-1034-achie-izhg5x January 20, 2024 11:25 Inactive
@dhenkel92 dhenkel92 temporarily deployed to backend-feat-1034-achie-izhg5x January 20, 2024 11:56 Inactive
dhenkel92
dhenkel92 reviewed Jan 20, 2024
View reviewed changes
common/achievement/template.ts Outdated Show resolved Hide resolved
common/achievement/util.ts Outdated Show resolved Hide resolved
common/achievement/util.ts Outdated Show resolved Hide resolved
integration-tests/15_achievements.ts Outdated Show resolved Hide resolved
integration-tests/15_achievements.ts Show resolved Hide resolved
integration-tests/15_achievements.ts Outdated Show resolved Hide resolved
integration-tests/15_achievements.ts Outdated Show resolved Hide resolved
integration-tests/15_achievements.ts Show resolved Hide resolved
integration-tests/15_achievements.ts Show resolved Hide resolved
integration-tests/15_achievements.ts Outdated Show resolved Hide resolved
@realmayus realmayus temporarily deployed to backend-feat-1034-achie-izhg5x January 22, 2024 13:21 Inactive
dhenkel92
dhenkel92 approved these changes Jan 23, 2024
View reviewed changes
common/achievement/template.ts Outdated Show resolved Hide resolved
@realmayus realmayus had a problem deploying to backend-feat-1034-achie-izhg5x January 25, 2024 12:15 Failure
@realmayus realmayus had a problem deploying to backend-feat-1034-achie-izhg5x January 25, 2024 12:15 Failure
@realmayus realmayus temporarily deployed to backend-feat-1034-achie-izhg5x January 25, 2024 13:16 Inactive
@LucasFalkowsky LucasFalkowsky merged commit 49dc8e5 into feat/achievements Jan 25, 2024
1 of 2 checks passed
@LucasFalkowsky LucasFalkowsky deleted the feat/1034-achievement-integration-tests branch January 25, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhenkel92 dhenkel92 dhenkel92 approved these changes

@LomyW LomyW Awaiting requested review from LomyW

Assignees

@LucasFalkowsky LucasFalkowsky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LucasFalkowsky @dhenkel92 @realmayus @LomyW