Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linter: refactor all dependecy circles #878

Merged
merged 13 commits into from
Nov 6, 2023

Conversation

Leo310
Copy link
Member

@Leo310 Leo310 commented Oct 28, 2023

This PR will resolve https://github.com/corona-school/project-user/issues/940
Each commit will solve one dependency cycle to keep a better overview of each refactor.

@realmayus realmayus temporarily deployed to backend-linter-refactor-tpduhj October 28, 2023 16:00 Inactive
@realmayus realmayus temporarily deployed to backend-linter-refactor-i0peio October 28, 2023 16:08 Inactive
@realmayus realmayus temporarily deployed to backend-linter-refactor-i0peio October 28, 2023 16:14 Inactive
Copy link
Member

@Jonasdoubleyou Jonasdoubleyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uh, very clean history - was easy to review :)

@Jonasdoubleyou
Copy link
Member

notification/index.ts is growing and growing ... I guess we need to rethink it's structure (someday)

@Leo310 Leo310 merged commit b593ea1 into master Nov 6, 2023
@Leo310 Leo310 deleted the linter/refactor-dependecy-cylces branch November 6, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants