Quality: Drop legacy dissolve reason columns, remove manual migration #1187
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back in #853, we migrated the integer-based
dissolveReason
todissolveReasonEnum
.Then,
dissolveReasonEnum
became obsolete when we allowed the user to select multipledissolveReasons
in #941.If the following query can be trusted,
we only have five matches where dissolveReasons != [dissolveReasonEnum]:
While I'm not 100% sure (due to logs being deleted regularly), I believe these are reactivated matches?
We ended up not writing to
dissolveReasonEnum
anymore; we're just updating dissolveReasons nowadays.I think we should be fine with dropping
dissolveReason
anddissolveReasonEnum
, but I would appreciate another set of eyes on this.