Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Webflow sync job pagination #1158

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Fix: Webflow sync job pagination #1158

merged 2 commits into from
Nov 13, 2024

Conversation

JeangelLF
Copy link
Contributor

Ticket

Resolves https://github.com/corona-school/project-user/issues/1377

What was done?

  • Added a basic pagination implementation to allow the job to delete the excess data from Webflow CMS
  • Added some try-catch to prevent the job from failing due to it not being able to create more items (It won't be able to do it, at least on the first try because right now Webflow has reached max capacity 😅)

Next steps

  • I'd try to monitor how it would work using the WEBFLOW_SYNC_DRY_RUN flag before actually running it on Prod.

@realmayus realmayus temporarily deployed to backend-fix-webflow-syn-olcvib November 13, 2024 10:24 Inactive
dhenkel92
dhenkel92 approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@dhenkel92 dhenkel92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks promising!
Thanks for the fix

@JeangelLF JeangelLF merged commit 3801116 into master Nov 13, 2024
2 checks passed
@JeangelLF JeangelLF deleted the fix/webflow-sync-job-pagination branch November 13, 2024 18:34
benjaminmay1 pushed a commit that referenced this pull request Nov 26, 2024
@JeangelLF @benjaminmay1
Fix: Webflow sync job pagination (#1158)
8ada945 
* feat: Add pagination to fetch webflow collection items

* fix: Prevent job from failing due to items not being created
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhenkel92 dhenkel92 dhenkel92 approved these changes

@Jonasdoubleyou Jonasdoubleyou Awaiting requested review from Jonasdoubleyou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JeangelLF @dhenkel92 @realmayus