fix: Reduce likelihood of race condition in Matching #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case two users are matched at the same time (e.g. through a Match run + manual matching) there is a certain likelihood that they are matched twice. By refetching the openMatchRequestCount right before creating the match, the likelihood of that happening is reduced. There might also be a bug in the new matching that creates duplicate matches, I hope if there is one, we will find it with this change.
JeangelLF
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case two users are matched at the same time (e.g. through a Match run + manual matching) there is a certain likelihood that they are matched twice. By refetching the openMatchRequestCount right before creating the match, the likelihood of that happening is reduced.
There might also be a bug in the new matching that creates duplicate matches, I hope if there is one, we will find it with this change.