Feat: Statistics - support pupil_screenings in knowsCoronaSchoolFrom #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jonasdoubleyou
approved these changes
Oct 11, 2024
| date_part('year', "createdAt"::date) AS year, | ||
| date_part('month', "createdAt"::date) AS month, | ||
| "knowsCoronaSchoolFrom" AS group | ||
| FROM "pupil_screening" |
There was a problem hiding this comment.
As there are N screenings for each pupil, doesnt this skew the statistics towards more active users?
There was a problem hiding this comment.
Good catch! How should we handle multiple screenings @FForstbach ? Should we only consider the most recent screening that has a knowsCoronaSchoolFrom entry?
There was a problem hiding this comment.
so i would say:
- only count once
- save the first real answer (dont know, or empty does not count)
- dont save subsequent entries (since we want to know how they first heard about coronaschool)
does that make sense @realmayus ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/corona-school/project-user/issues/1204.