feat: conduct subcourse appointment metric and mutation adjustments

corona-school · Jan 19, 2024 · ca14256 · ca14256
1 parent b3cfa90
commit ca14256
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/common/achievement/metric.ts b/common/achievement/metric.ts
@@ -56,6 +56,14 @@ const batchOfMetrics = [
         return 1;
     }),
 
+    /* CONDUCTED SUBCOURSE APPOINTMENT */
+    createMetric('student_conducted_subcourse_appointment', ['student_joined_subcourse_meeting'], () => {
+        return 1;
+    }),
+    createMetric('pupil_conducted_subcourse_appointment', ['pupil_joined_subcourse_meeting'], () => {
+        return 1;
+    }),
+
     /* REGULAR MATCH LEARNING */
     createMetric('pupil_match_learned_regular', ['pupil_joined_match_meeting'], () => {
         return 1;

diff --git a/common/achievement/template.ts b/common/achievement/template.ts
@@ -57,7 +57,10 @@ async function getTemplatesByMetrics(metricsForAction: Metric[]) {
         return [];
     }
     for (const metric of metricsForAction) {
-        templatesForAction = [...templatesForAction, ...templatesByMetric.get(metric.metricName)];
+        const templatesForMetric = templatesByMetric.get(metric.metricName);
+        if (templatesForMetric) {
+            templatesForAction = [...templatesForAction, ...templatesForMetric];
+        }
     }
     return templatesForAction;
 }

diff --git a/graphql/achievement/mutations.ts b/graphql/achievement/mutations.ts
@@ -33,7 +33,7 @@ export class MutateAchievementResolver {
 
     @Mutation((returns) => Boolean)
     @AuthorizedDeferred(Role.ADMIN, Role.OWNER)
-    async subcourseMeetingJoin(@Ctx() context: GraphQLContext, @Arg('matchId') subcourseId: number) {
+    async subcourseMeetingJoin(@Ctx() context: GraphQLContext, @Arg('subcourseId') subcourseId: number) {
         const { user } = context;
         const subcourse = await prisma.subcourse.findUnique({ where: { id: subcourseId }, include: { course: true, lecture: true } });
         await hasAccess(context, 'Subcourse', subcourse);