drop legacy dissolve reason columns, remove manual migration

corona-school · Jan 20, 2025 · 3e5ad68 · 3e5ad68
1 parent a6155b2
commit 3e5ad68
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 25 deletions.
diff --git a/common/achievement/evaluate.spec.ts b/common/achievement/evaluate.spec.ts
@@ -254,9 +254,7 @@ function createTestMatch({ lectures }: { lectures: lecture[] }): MatchWithLectur
         dissolved: false,
         dissolvedAt: null,
         dissolvedBy: null,
-        dissolveReason: null,
         dissolveReasons: [],
-        dissolveReasonEnum: null,
         didHaveMeeting: true,
         proposedTime: null,
         createdAt: new Date(),

diff --git a/jobs/list.ts b/jobs/list.ts
@@ -11,7 +11,7 @@ import syncToWebflow from './periodic/sync-to-webflow';
 import { postStatisticsToSlack } from './slack-statistics';
 import notificationsEndedYesterday from './periodic/notification-courses-ended-yesterday';
 import { assignOriginalAchievement } from './manual/assign_original_achievement';
-import migrateDissolveReasonEnum from './migrate-dissolve-reason-enum';
+
 export const allJobs = {
     cleanupSecrets,
     dropOldNotificationContexts,
@@ -25,7 +25,6 @@ export const allJobs = {
     flagInactiveConversationsAsReadonly,
     notificationsEndedYesterday,
     checkReminders,
-    migrateDissolveReasonEnum,
 
     assignOriginalAchievement,
 

diff --git a/jobs/migrate-dissolve-reason-enum.ts b/jobs/migrate-dissolve-reason-enum.ts
diff --git a/prisma/migrations/20250120150738_remove_legacy_dissolve_reason/migration.sql b/prisma/migrations/20250120150738_remove_legacy_dissolve_reason/migration.sql
@@ -0,0 +1,10 @@
+/*
+  Warnings:
+
+  - You are about to drop the column `dissolveReason` on the `match` table. All the data in the column will be lost.
+  - You are about to drop the column `dissolveReasonEnum` on the `match` table. All the data in the column will be lost.
+
+*/
+-- AlterTable
+ALTER TABLE "match" DROP COLUMN "dissolveReason",
+DROP COLUMN "dissolveReasonEnum";
diff --git a/prisma/schema.prisma b/prisma/schema.prisma
@@ -452,13 +452,6 @@ model match {
   dissolved             Boolean            @default(false)
   dissolvedAt           DateTime?          @db.Timestamp(6)
   dissolvedBy           dissolved_by_enum?
-  // At some point in time the dissolve UI of pupils and students deviated,
-  // and they would write different ids for the same dissolve reason into this field
-  // As we do not store who dissolved the match, it is quite hard to interpret this number:
-  // (but you can make some weird joins with the log table to find out who dissolved it)
-  // dissolveReason is DEPRECATED, use dissolveReasonEnum instead
-  dissolveReason        Int?
-  dissolveReasonEnum    dissolve_reason?
   dissolveReasons       dissolve_reason[]  @default([])
   didHaveMeeting        Boolean            @default(false) // whether the match partners did actually have an initial meeting
   // DEPRECATED: At some point students could suggest a first meeting time to pupils when they got the match