Clement remove bold font weight everywhere #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 82. |
andrew032011
reviewed
Dec 7, 2024
| @@ -49,7 +49,7 @@ const Initiative = ({ | |||
| width >= LAPTOP_BREAKPOINT ? inter.className : ibm_plex_mono.className | |||
| }`} | |||
| > | |||
| {parts.map((part, index) => (part === eventName ? <b key={index}>{part}</b> : part))} | |||
| {parts.map((part, index) => part)} | |||
There was a problem hiding this comment.
Wait can't we just do parts here then?
There was a problem hiding this comment.
LOL i accidentally edited smth oops
| @@ -15,8 +15,7 @@ | |||
| "height": 328 | |||
| }, | |||
| "description": "At the Tompkins County Public Library, our members give children in the Ithaca community the opportunity to grow and learn about other technical careers. We introduce code and design through beginner-friendly, interactive workshops with Cornell students, providing individualized feedback. Young students can learn Scratch to create their own games and animations, and Figma to make eye-catching visuals with shapes, colors, and more!", | |||
| "mobileDescription": "@Tompkins County Public Library, we introduced code & design with workshops that taught Figma and Sketch.", | |||
| "eventName": "Tompkins County Public Library" | |||
There was a problem hiding this comment.
this is causing a linting error, if we not using eventName anywhere we could remove it from everything else, and also from the type
There was a problem hiding this comment.
wait ok i messed up smth but i think i fixed it here/
andrew032011
reviewed
Dec 8, 2024
| @@ -49,7 +46,7 @@ const Initiative = ({ | |||
| width >= LAPTOP_BREAKPOINT ? inter.className : ibm_plex_mono.className | |||
| }`} | |||
| > | |||
| {parts.map((part, index) => (part === eventName ? <b key={index}>{part}</b> : part))} | |||
| {description} | |||
| </p> | |||
| </article> | |||
| ); | |||
There was a problem hiding this comment.
FYI eventName still appears below too (line 68 and 70), and type checker caught it
There was a problem hiding this comment.
ohh good catch, should be fixed now i think...
andrew032011
approved these changes
Dec 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes this
removes font weight bold
sorry no time for screenshots 🙃