Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website: Add Sample Projects #783

Merged
merged 6 commits into from
Dec 14, 2024
Merged

Website: Add Sample Projects #783

merged 6 commits into from
Dec 14, 2024

Conversation

cchrischen
Copy link
Contributor

Summary

Add sample projects from this semester's trends class. Currently have 4/5 we asked to see how the components looks when populated with data. Images were compressed to be < 300kb.

Notion/Figma Link

Notion

Test Plan

see netlify deploy

@cchrischen cchrischen requested a review from a team as a code owner December 7, 2024 18:32
@dti-github-bot
Copy link
Member

dti-github-bot commented Dec 7, 2024

[diff-counting] Significant lines: 24.

@andrew032011
Copy link
Collaborator

Might need to workshop which screenshots we pick.

@andrew032011 andrew032011 requested a review from Bookie0 December 7, 2024 18:49
Copy link
Collaborator

@Bookie0 Bookie0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove the animation when the project accordion opens up?
like it slowly fades in, but i dont think we're having this animation show up anywhere else

@cchrischen cchrischen requested a review from Bookie0 December 12, 2024 18:10
Copy link
Collaborator

@Bookie0 Bookie0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

can we also remove the red on open state

Screenshot 2024-12-12 at 4 59 29 PM

},
{
"title": "CU Lost and Found",
"description": "A platform that helps students recover their lost belongings through crowdsourced data",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"description": "A platform that helps students recover their lost belongings through crowdsourced data",
"description": "A platform that helps students recover their lost belongings through crowdsourced data.",

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(adding period for consistency with the descriptions of the other projects)

"description": "This project is about blah blah blah blah blah blah blah blah blah blah blah blah blah.",
"imageSrc": "https://via.placeholder.com/400"
"title": "Off Campus Groups",
"description": "Centralized platform to find, join & create new events for OFF-campus events",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"description": "Centralized platform to find, join & create new events for OFF-campus events",
"description": "Centralized platform to find, join & create new events for OFF-campus events.",

@andrew032011 andrew032011 requested a review from Bookie0 December 14, 2024 00:49
@cchrischen cchrischen merged commit 14d52aa into main Dec 14, 2024
17 checks passed
@cchrischen cchrischen deleted the cc/website/sample-projects branch December 14, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants