Set up firebase for coffee chat bingo #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 32. |
oscarwang20
requested changes
Mar 27, 2024
backend/src/types/DataTypes.d.ts
Outdated
Comment on lines
101
to
107
| export type DBCoffeeChat = { | ||
| uuid: string; | ||
| members: firestore.DocumentReference[]; | ||
| image: string; | ||
| category: string; | ||
| description: string; | ||
| status: string; |
There was a problem hiding this comment.
Make sure to add this new type to common-types/index.d.ts as well!
andrew032011
approved these changes
Mar 31, 2024
backend/src/types/DataTypes.d.ts
Outdated
| image: string; | ||
| category: string; | ||
| description: string; | ||
| status: string; |
There was a problem hiding this comment.
Change status type to be Status, not string.
| @@ -191,3 +191,13 @@ interface Shoutout { | |||
| readonly hidden: boolean; | |||
| readonly uuid: string; | |||
| } | |||
|
|
|||
| interface CoffeeChat { | |||
| readonly uuid: string; | |||
There was a problem hiding this comment.
As you can see (from above), though we never followed this rule, we theoretically should be making all these fields readonly. Don't worry about the above ones but let's fix this one.
oscarwang20
approved these changes
Apr 15, 2024
oscarwang20
pushed a commit
that referenced
this pull request
May 6, 2024
* initial commit * add dbcoffeechat type * testing file * testing * rm testing file * add type into common types * make description non optional * add date * fix nits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request is the first step towards implementing coffee chat bingo.
coffee-chatsinfirebase.tsNotion/Figma Link
https://www.notion.so/Set-up-Firebase-for-coffee-chat-bingo-3d6c635217ec48a8aaf08ed7a5e4f197
Test Plan
Notes